Use WAL journaling mode by default if custom WAL methods are specified - #115
Merged
Conversation
xPreMainDbOpen hook was only called in case of non-null WAL pathname, which is a minor mistake - let's fix it.
This patch adds best-effort logic to switch to WAL journaling mode as soon as a database connection is open, if the database was open with custom WAL methods defined. It's performed by calling an extra "pragma journal_mode=wal" query at the end of the initialization process, and thus it's not guaranteed to succeed, e.g. in readonly mode.
The test now ensures that the database is already open in WAL mode by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's reasonable to assume that a database open with custom WAL methods should default to WAL journaling mode.
This commit comes with an updated test which ensures that the database is open in WAL mode without having to resort to calling
PRAGMA journal_mode=walmanually.This pull request is #105 revamped, where the switch to WAL was done few layers below, which broke a few SQLite invariants and led to bugs.